Re: [Qemu-devel] [PATCH 2/6] json-lexer: Handle missing escapes

[Luiz Capitulino]

On Wed, 19 May 2010 16:44:47 -0500
Anthony Liguori <address@hidden> wrote:

> On 05/19/2010 04:15 PM, Luiz Capitulino wrote:
> > The JSON escape sequence "\/" and "\\" are valid and should be
> > handled.
> >
> > Signed-off-by: Luiz Capitulino<address@hidden>
> >    
> 
> Good catch.

 I think there's another issue in the handling of strings.

 The spec says that valid unescaped chars are in the following range:

    unescaped = %x20-21 / %x23-5B / %x5D-10FFFF

 But we do:

    [IN_DQ_STRING] = {
        [1 ... 0xFF] = IN_DQ_STRING,
        ['\\'] = IN_DQ_STRING_ESCAPE,
        ['"'] = IN_DONE_STRING,
    },

 Shouldn't we cover 0x20 .. 0xFF instead?