[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/22] tcg-i386: Tidy ext8u and ext16u operation
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 03/22] tcg-i386: Tidy ext8u and ext16u operations. |
|
Date: |
Thu, 20 May 2010 07:40:59 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Thunderbird/3.0.4 |
On 05/20/2010 07:04 AM, Aurelien Jarno wrote:
>> Do you have tried to compare the generated code before and after your
>> patch? I expect a few cases where your patch has some drawbacks, so I
>> don't know if there is a net gain on the size of the translated code.
>>
>
> I have done a quick test on /bin/ls.
> | instr | size |
> +--------+--------+
> before | 101305 | 344770 |
> after | 101258 | 344829 |
>
> In short a small gain in the number of instructions, and a small loss in
> the size of the translated code.
That was pretty much the test I would have done.
So where are we? Is the patch acceptable as-is, or should I be
re-writing it without the constraints change?
r~