[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-blk: Avoid zeroing every request struct
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] virtio-blk: Avoid zeroing every request structure |
Date: |
Fri, 21 May 2010 12:17:00 +0100 |
On Tue, May 18, 2010 at 9:43 PM, Stefan Hajnoczi <address@hidden> wrote:
> I'll rerun with profiling tomorrow to see if calloc() makes a
> difference for general qemu_mallocz() usage.
The results are unchanged for direct calloc() instead of
malloc+memset. The memset() symbol is still at the top of the profile
because glibc is using it internally for calloc().
In theory calloc() allows libc to do optimizations so I think changing
qemu_mallocz() to use calloc() is reasonable.
Stefan
- Re: [Qemu-devel] [PATCH] virtio-blk: Avoid zeroing every request structure, (continued)
Re: [Qemu-devel] [PATCH] virtio-blk: Avoid zeroing every request structure, Corentin Chary, 2010/05/18