[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH v2 12/15] monitor: Add basic device state vi

From: Anthony Liguori
Subject: Re: [Qemu-devel] Re: [PATCH v2 12/15] monitor: Add basic device state visualization
Date: Mon, 24 May 2010 15:22:18 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 05/24/2010 07:51 AM, Luiz Capitulino wrote:
On Sun, 23 May 2010 09:57:43 +0200
Jan Kiszka<address@hidden>  wrote:

Avi Kivity wrote:

+- "full": report full state (json-bool, optional)

Is this needed for QMP?  The client can always truncate it to any length.
The effect may not be needed for QMP, but I do need this channel from
the command line to the monitor pretty-printer. I could just stick
"full": json-bool back into the return dict, but that would look somehow
strange IMO.
  We could have a form of optional key which is only present internally,
we have that async commands.

I'd rather see two separate commands with an internal mechanism to make direct QMP calls. The human monitor can be implemented in terms of the QMP call but it should be in terms of the human monitor invoking the QMP command such that it can munge the output as it sees appropriate.


Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]