[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 7/7] trace: Trace virtqueue operations

From: Stefan Hajnoczi
Subject: [Qemu-devel] Re: [PATCH 7/7] trace: Trace virtqueue operations
Date: Tue, 25 May 2010 14:27:59 +0100

On Tue, May 25, 2010 at 1:04 PM, Avi Kivity <address@hidden> wrote:
> Those %ps are more or less useless.  We need better ways of identifying
> them.

You're right, the vq pointer is useless in isolation.  We don't know
which virtio device or which virtqueue number.

With the full context of a trace it would be possible to correlate the
vq pointer if we had trace events for vdev and vq setup.

Adding custom formatters is could be tricky since the format string is
passed only to tracing backends that use it, like UST.  And UST uses
its own sprintf implementation which we don't have direct control

I think we just need to guarantee that any pointer can be correlated
with previous trace entries that give context for that pointer.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]