[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v3 10/17] QMP: Reserve namespace for complex obj
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH v3 10/17] QMP: Reserve namespace for complex object classes |
Date: |
Fri, 28 May 2010 00:20:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Luiz Capitulino wrote:
> On Sun, 23 May 2010 12:59:23 +0200
> Jan Kiszka <address@hidden> wrote:
>
>> From: Jan Kiszka <address@hidden>
>>
>> This reserves JSON objects that contain the key '__class__' for QMP-specific
>> complex objects. First user will be the buffer class.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>> ---
>> QMP/qmp-spec.txt | 16 +++++++++++++---
>> 1 files changed, 13 insertions(+), 3 deletions(-)
>>
>> diff --git a/QMP/qmp-spec.txt b/QMP/qmp-spec.txt
>> index 9d30a8c..fa1dd62 100644
>> --- a/QMP/qmp-spec.txt
>> +++ b/QMP/qmp-spec.txt
>> @@ -146,6 +146,15 @@ The format is:
>> For a listing of supported asynchronous events, please, refer to the
>> qmp-events.txt file.
>>
>> +2.6 Complex object classes
>> +--------------------------
>> +
>> +JSON objects that contain the key-value pair '"__class__": json-string' are
>
> I'm not strong about this, but it's better to call it just a 'pair', as
> 'value'
> is a bit problematic because of json-value.
Hmm, the official term is "name/value pairs". Will use that instead.
>
>> +reserved for QMP-specific complex object classes that. QMP specifies which
>
> Early full stop?
Obviously. I just don't remember what I wanted to add.
>
>> +further keys each of these objects include and how they are encoded.
>> +
>> +So far, no complex object class is specified.
>> +
>> 3. QMP Examples
>> ===============
>>
>> @@ -229,9 +238,10 @@ avoid modifying QMP. Both upstream and downstream need
>> to take care to
>> preserve long-term compatibility and interoperability.
>>
>> To help with that, QMP reserves JSON object member names beginning with
>> -'__' (double underscore) for downstream use ("downstream names"). This
>> -means upstream will never use any downstream names for its commands,
>> -arguments, errors, asynchronous events, and so forth.
>> +'__' (double underscore) for downstream use ("downstream names").
>> Downstream
>> +names MUST NOT end with '__' as this pattern is reserved for QMP-defined
>> JSON
>> +object classes. Upstream will never use any downstream names for its
>> +commands, arguments, errors, asynchronous events, and so forth.
>
> Suggest mentioning subsection 2.6.
OK.
Thanks,
Jan
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v3 12/17] monitor: return length of printed string via monitor_[v]printf, Jan Kiszka, 2010/05/23
[Qemu-devel] [PATCH v3 16/17] QMP: Fix python helper /wrt long return strings, Jan Kiszka, 2010/05/23
[Qemu-devel] [PATCH v3 10/17] QMP: Reserve namespace for complex object classes, Jan Kiszka, 2010/05/23
[Qemu-devel] [PATCH v3 14/17] monitor: Add basic device state visualization, Jan Kiszka, 2010/05/23
[Qemu-devel] [PATCH v3 17/17] QMP: Add support for buffer class to qmp python helper, Jan Kiszka, 2010/05/23