[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 02/15] qdev: Fix scanning across single-bus d

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v2 02/15] qdev: Fix scanning across single-bus devices
Date: Sat, 29 May 2010 09:38:18 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

[cc: kraxel]

Jan Kiszka <address@hidden> writes:

> From: Jan Kiszka <address@hidden>
> As long as we allow /dev.1 as shortcut for /dev1/bus1, we also have to
> make sure that /dev1/dev2 works for /dev1/bus1/dev2/bus2 - as long as
> there is only one child bus per device.

We auto-root a path not starting with '/' via convention "first
component is ID then" (I like that).  We auto-complete a path ending
with a device when we want a bus (a bit too clever).  Auto-inserting bus
names in the middle is too clever by half!

Such cleverness can be convenient in the human monitor, but all it adds
to QMP is complexity.

I'm worried about possibly ambigous interpretation of paths.  Would be
bad if a path could name different node after we add something to the
tree.  I *think* your fine print makes that impossible, but it's not
exactly obvious.  Heck, I could be wrong.

Wouldn't it be better to put the convenience into the interactive
completion function?  That way we keep it out of QMP.

Subject is misleading, it's a feature, not a bug fix.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]