[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 02/15] qdev: Fix scanning across single-bus d

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH v2 02/15] qdev: Fix scanning across single-bus devices
Date: Mon, 31 May 2010 11:45:13 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4

On 05/29/10 09:38, Markus Armbruster wrote:
[cc: kraxel]

Jan Kiszka<address@hidden>  writes:

From: Jan Kiszka<address@hidden>

As long as we allow /dev.1 as shortcut for /dev1/bus1, we also have to
make sure that /dev1/dev2 works for /dev1/bus1/dev2/bus2 - as long as
there is only one child bus per device.

We auto-root a path not starting with '/' via convention "first
component is ID then" (I like that).  We auto-complete a path ending
with a device when we want a bus (a bit too clever).

... only if there is a single child bus only (i.e. it isn't ambiguous). Which is the common case though.

Auto-inserting bus
names in the middle is too clever by half!

Yea. I have to agree here. It can only work reliably if you make sure all your devices have unique ids. In which case there is no need to reference dev1 at all, you can just use the "first component is ID then" mechanism for dev2.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]