[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/8] sparc64: fix missing address masking
From: |
Igor Kovalenko |
Subject: |
Re: [Qemu-devel] [PATCH 2/8] sparc64: fix missing address masking |
Date: |
Wed, 2 Jun 2010 08:29:32 +0400 |
On Wed, Jun 2, 2010 at 12:44 AM, Richard Henderson <address@hidden> wrote:
> On 06/01/2010 01:12 PM, Igor V. Kovalenko wrote:
>> + if ((env->pstate & PS_AM) && is_translating_asi(asi)) {
>> + addr &= 0xffffffffULL;
>> + }
>
> I suggest that these be written instead as
>
> if (is_translating_asi(asi)) {
> addr = address_mask(addr);
> }
>
> That should allow you to remove some of the ifdefs.
All address masking is done for sparc64 target only, sparc32 does not
have the notion of translating asi.
I think it's better to do debug printf macro trick then but I see no
real benefit at the moment.
--
Kind regards,
Igor V. Kovalenko
[Qemu-devel] [PATCH 3/8] sparc64: fix 32bit load sign extension, Igor V. Kovalenko, 2010/06/01