[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-blk: assign a default serial number if n
|
From: |
Ryan Harper |
|
Subject: |
Re: [Qemu-devel] [PATCH] virtio-blk: assign a default serial number if none provided |
|
Date: |
Wed, 2 Jun 2010 06:42:34 -0500 |
|
User-agent: |
Mutt/1.5.6+20040907i |
* Michael Tokarev <address@hidden> [2010-06-02 01:57]:
> 02.06.2010 05:48, Ryan Harper wrote:
> []
> > hw/virtio-blk.c | 3 +++
> >+ if (strlen(s->sn) == 0) {
>
> Just out of curiocity (not that it is wrong or inefficient):
> why
> strlen(s->sn)
> and not, say,
> !s->sn[0]
> ?
Just matching how it's done in hw/ide/core.c:ide_init_drive()
--
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
address@hidden