qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH V3 2/3] qemu: Generic asynchronous threading fra


From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH V3 2/3] qemu: Generic asynchronous threading framework to offload tasks
Date: Thu, 03 Jun 2010 14:37:45 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Lightning/1.0b2pre Thunderbird/3.0.4

On 06/03/2010 01:41 PM, Corentin Chary wrote:
 +    if (sigprocmask(SIG_SETMASK,&set,&oldset)) {
 +        async_abort(errno, "sigprocmask");
 +    }
 +
 +    qemu_thread_create_attr(&thread,&attr, async_worker_thread, queue);
 +
 +    if (sigprocmask(SIG_SETMASK,&oldset, NULL)) {
 +        async_abort(errno, "sigprocmask restore");
 +    }

I wonder if qemu_thread_create shouldn't block all signals by default. Then the cpu and iothreads can unblock whatever they want.

I'll send a patch shortly.

In any case, please use pthread_sigmask instead of sigprocmask.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]