Re: [Qemu-devel] [PATCH] Add exit notifiers.

[Stefan Hajnoczi]

On Fri, Jun 4, 2010 at 10:35 AM, Gerd Hoffmann <address@hidden> wrote:
> Hook up any cleanup work which needs to be done here.  Advantages over
> using atexit(3):
>
>  (1) You get passed in a pointer to the notifier.  If you embed that
>      into your state struct you can use container_of() to get get your
>      state info.
>  (2) You can unregister, say when un-plugging a device.

This looks useful to me.  Just yesterday I added an atexit(3) case for
some local hacking.

> diff --git a/roms/seabios b/roms/seabios
> index 8f469b9..7d09d0e 160000
> --- a/roms/seabios
> +++ b/roms/seabios
> @@ -1 +1 @@
> -Subproject commit 8f469b9676127ba6bb52609d89ec774e61db0ee1
> +Subproject commit 7d09d0e3ba11310e973d4302c7fcc3fc2184e04c

This hunk seems unrelated to your commit.

> diff --git a/vl.c b/vl.c
> index ac1a998..1577566 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2127,6 +2130,21 @@ static BOOL WINAPI qemu_ctrl_handler(DWORD type)
>
>  #ifndef _WIN32
>
> +void qemu_add_exit_notifier(Notifier *notify)

Why #ifndef _WIN32?  I think this patch will break _WIN32 builds.

Stefan