[Qemu-devel] Re: [PATCH 6/6] apic: avoid using CPUState internals

[Paolo Bonzini]

On 06/09/2010 09:59 PM, Blue Swirl wrote:
> > >   struct APICState {
> > > -    CPUState *cpu_env;
> > > +    void *cpu_env;
> >
> > I proposed having an opaque CPUState type in hw/ but it was rejected. But I
> > don't think using a void pointer is any better.
>
> It's not necessary for the patch. Maybe it's possible to avoid all
> CPUState references in apic.c by pushing the dependencies to pc.c. It
> could affect performance though.

I think it's unnecessary.  But I'd leave CPUState

Paolo