qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 13/13] blockdev: New -blockdev to define a host


From: Markus Armbruster
Subject: [Qemu-devel] Re: [PATCH 13/13] blockdev: New -blockdev to define a host block device
Date: Thu, 10 Jun 2010 18:32:14 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

Paolo Bonzini <address@hidden> writes:

> On 06/02/2010 06:55 PM, Markus Armbruster wrote:
>> * Like -drive, -blockdev ignores cache= silently when snapshot=on.  Do
>>    we really want that?
>
> Yes, the changes are throw-away by definition.  Might as well use
> cache=unsafe.

I understand why that's the most sensible cache setting.  But if the
user explicitly asks for something else, I think we better give it to
him, or tell him no.  Ignoring him silently isn't nice.

>> +    if (snapshot) {
>> +        /* always use write-back with snapshot */
>> +        /* FIXME ignores explicit cache= *silently*; really want that? */
>> +        flags &= ~BDRV_O_CACHE_MASK;
>> +        flags |= (BDRV_O_SNAPSHOT | BDRV_O_CACHE_WB);
>> +        flags |= BDRV_O_SNAPSHOT;
>
> Cut and paste?

Pasto indeed, will fix.  Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]