[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] qemu-option: Fix uninitialized value in append_opti
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH] qemu-option: Fix uninitialized value in append_option_parameter |
Date: |
Fri, 11 Jun 2010 10:19:41 +0200 |
When dest is NULL, i.e. a new copy of the list is created, we don't get a
properly terminated list after the realloc. Initialize it as an empty list.
Signed-off-by: Kevin Wolf <address@hidden>
---
Xudong, can you please try this one? I think it should fix your qemu-img
problem.
qemu-option.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/qemu-option.c b/qemu-option.c
index acd74f9..f884865 100644
--- a/qemu-option.c
+++ b/qemu-option.c
@@ -378,6 +378,7 @@ QEMUOptionParameter
*append_option_parameters(QEMUOptionParameter *dest,
num_options += count_option_parameters(list);
dest = qemu_realloc(dest, (num_options + 1) * sizeof(QEMUOptionParameter));
+ dest[num_dest_options].name = NULL;
while (list && list->name) {
if (get_option_parameter(dest, list->name) == NULL) {
--
1.6.6.1
- [Qemu-devel] [PATCH] qemu-option: Fix uninitialized value in append_option_parameter,
Kevin Wolf <=