[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 2/7] No need for kvm_init() stub as already defi
|
From: |
Jes Sorensen |
|
Subject: |
[Qemu-devel] Re: [PATCH 2/7] No need for kvm_init() stub as already defined in qemu-kvm.h |
|
Date: |
Tue, 15 Jun 2010 15:59:38 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Lightning/1.0b2pre Thunderbird/3.0.4 |
On 06/15/10 15:34, Paolo Bonzini wrote:
> On 06/15/2010 01:04 PM, address@hidden wrote:
>> From: Jes Sorensen<address@hidden>
>>
>> No need for kvm_init() stub in kvm-stub.c as already defined in
>> qemu-kvm.h
>
> Why not keep the other one and match upstream? Instead, I'd remove this
> one and move kvm_inject_x86_mce to kvm-stub.c.
>
> Files that upstream compiles only once will be compiled only without
> CONFIG_KVM, and will always call the stubs if these are in qemu-kvm.h.
You're right, time for a v3 of the patch....
Cheers,
Jes
[Qemu-devel] [PATCH 4/7] Build certain drivers for MIPS as well., Jes . Sorensen, 2010/06/15
[Qemu-devel] [PATCH 5/7] Only export phys_mem create functions for !CONFIG_USER_ONLY builds, Jes . Sorensen, 2010/06/15
[Qemu-devel] [PATCH 3/7] time_drift_fix is x86 only, rather than !ia64, Jes . Sorensen, 2010/06/15
[Qemu-devel] [PATCH 7/7] Only accept -no-hpet for i386 targets, Jes . Sorensen, 2010/06/15