qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 1/2] qemu-io: retry fgets() when errno is EINTR


From: Kevin Wolf
Subject: [Qemu-devel] Re: [PATCH 1/2] qemu-io: retry fgets() when errno is EINTR
Date: Wed, 16 Jun 2010 13:04:47 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4

Am 15.06.2010 19:53, schrieb MORITA Kazutaka:
> posix-aio-compat sends a signal in aio operations, so we should
> consider that fgets() could be interrupted here.
> 
> Signed-off-by: MORITA Kazutaka <address@hidden>
> ---
>  cmd.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/cmd.c b/cmd.c
> index 2336334..460df92 100644
> --- a/cmd.c
> +++ b/cmd.c
> @@ -272,7 +272,10 @@ fetchline(void)
>               return NULL;
>       printf("%s", get_prompt());
>       fflush(stdout);
> +again:
>       if (!fgets(line, MAXREADLINESZ, stdin)) {
> +             if (errno == EINTR)
> +                     goto again;
>               free(line);
>               return NULL;
>       }

This looks like a loop replaced by goto (and braces are missing). What
about this instead?

do {
    ret = fgets(...)
} while (ret == NULL && errno == EINTR)

if (ret == NULL) {
   fail
}

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]