Re: [Qemu-devel] [PATCH 02/10] qdev: export qdev_reset() for later use.

[Markus Armbruster]

Isaku Yamahata <address@hidden> writes:

> export qdev_reset() for later use.
>
> Signed-off-by: Isaku Yamahata <address@hidden>
> ---
>  hw/qdev.c |   13 +++++++++----
>  hw/qdev.h |    1 +
>  2 files changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/hw/qdev.c b/hw/qdev.c
> index 61f999c..378f842 100644
> --- a/hw/qdev.c
> +++ b/hw/qdev.c
> @@ -256,13 +256,18 @@ DeviceState *qdev_device_add(QemuOpts *opts)
>      return qdev;
>  }
>  
> -static void qdev_reset(void *opaque)
> +void qdev_reset(DeviceState *dev)
>  {
> -    DeviceState *dev = opaque;
>      if (dev->info->reset)
>          dev->info->reset(dev);
>  }
>  
> +static void qdev_reset_fn(void *opaque)
> +{
> +    DeviceState *dev = opaque;
> +    qdev_reset(dev);
> +}
> +

Nitpick: why the local variable?

[...]