[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/19] Convert drive options to use enumeration
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 06/19] Convert drive options to use enumeration data type |
Date: |
Sat, 26 Jun 2010 09:07:41 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
"Daniel P. Berrange" <address@hidden> writes:
> This converts the drive options if, trans, media, cache, aio,
> rerror and werror to use the QEMU_OPT_ENUM datatype. This
> standardizes the string parsing and error reporting
>
> $ qemu -drive file=foo,werror=stop3
> qemu: -drive file=foo,if=mtd,werror=stop3: Parameter 'werror' expects
> report, ignore, enospc, stop
>
> $ qemu -readconfig bar.cfg
> qemu:bar.cfg:6: Parameter 'werror' expects report, ignore, enospc, stop
> read config bar.cfg: Invalid argument
>
> * block.c: Implementations for all enumerations
> * block.h, sysemu.h: Declare enumerations
> * qemu-config.c: Convert if, trans, media, cache, aio,
> rerror and werror to use the QEMU_OPT_ENUM
> * vl.c: Remove handcrafted string -> int conversions in drive_init
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
Conflicts mightily with my work, but I love it anyway :)
- Re: [Qemu-devel] [PATCH 16/19] Add a query-netdev command to QMP, (continued)
- [Qemu-devel] [PATCH 19/19] Add a -capabilities argument to allow easy query for static QEMU info, Daniel P. Berrange, 2010/06/07
- [Qemu-devel] [PATCH 06/19] Convert drive options to use enumeration data type, Daniel P. Berrange, 2010/06/07
- Re: [Qemu-devel] [PATCH 00/19] RFC: Reporting QEMU binary capabilities, Anthony Liguori, 2010/06/07
- Re: [Qemu-devel] [PATCH 00/19] RFC: Reporting QEMU binary capabilities, Anthony Liguori, 2010/06/07
- Re: [Qemu-devel] [PATCH 00/19] RFC: Reporting QEMU binary capabilities, Markus Armbruster, 2010/06/26