[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multip
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev |
Date: |
Sat, 26 Jun 2010 16:44:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Christoph Hellwig <address@hidden> writes:
> On Fri, Jun 25, 2010 at 06:53:28PM +0200, Markus Armbruster wrote:
>> For instance, -device scsi-disk,drive=foo -device scsi-disk,drive=foo
>> happily creates two SCSI disks connected to the same block device.
>> It's all downhill from there.
>
> And from some quick testing a while ago the thing seems to actually
> work. Not that I think that it is a good idea, but do we want to change
> behaviour in that respect?
Valid question. I'd answer yes. It's an easy error to make, and likely
to end in massive file system corruption in the guest.
>> Device usb-storage deliberately attaches twice to the same blockdev,
>> which fails with the fix in place. Detach before the second attach
>> there.
>
> Can anyone explain what the hell usb storage is actually trying to do
> with the two drives?
It's actually a SCSI controller with a single drive on its single bus.
-device usb-storage,drive=foo creates *two* devices: usb-storage itself,
which serves as SCSI controller, and scsi-disk for the drive.
usb-storage copies its drive property to scsi-disk.
I don't like this. Each -device should create just one device.
- [Qemu-devel] [PATCH 00/12] More block-related fixes and cleanups, Markus Armbruster, 2010/06/25
- [Qemu-devel] [PATCH 01/12] scsi: scsi_bus_legacy_handle_cmdline() can fail, fix callers, Markus Armbruster, 2010/06/25
- [Qemu-devel] [PATCH 06/12] qdev: Decouple qdev_prop_drive from DriveInfo, Markus Armbruster, 2010/06/25
- [Qemu-devel] [PATCH 12/12] pc: Fix CMOS info for drives defined with -device, Markus Armbruster, 2010/06/25
- [Qemu-devel] [PATCH 05/12] blockdev: Clean up automatic drive deletion, Markus Armbruster, 2010/06/25
- [Qemu-devel] [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev, Markus Armbruster, 2010/06/25
- [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev, Christoph Hellwig, 2010/06/26
- Re: [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev,
Markus Armbruster <=
- Re: [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev, Christoph Hellwig, 2010/06/27
- Re: [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev, Kevin Wolf, 2010/06/28
- Re: [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev, Christoph Hellwig, 2010/06/28
- Re: [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev, Kevin Wolf, 2010/06/28
- Re: [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev, Markus Armbruster, 2010/06/30
- Re: [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev, Kevin Wolf, 2010/06/30
- Re: [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev, Gerd Hoffmann, 2010/06/29
- Re: [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev, Markus Armbruster, 2010/06/30
[Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev, Kevin Wolf, 2010/06/29