[Qemu-devel] Re: [PATCH 4/4] require #define NEED_GLOBAL_ENV for files that need the global register variable

[Paolo Bonzini]

On 06/29/2010 03:51 PM, Paolo Bonzini wrote:
> On 06/29/2010 01:30 PM, Paul Brook wrote:
> > I don't understand what this is supposed to achieve. The inclusion
> > of exec.h is what defines whether this global variable is
> > available. Just as importantly, it also prevents code clobbering
> > this value. Having one without the other makes no sense.
> >
> > Making "env" available without including exec.h would be a
> > different problem, but we never do that and would probably indicate
> > we're doing something else wrong.
>
> Paul, I agree but I was told to do something different.

BTW, this may be useful for one thing: being able to include exec.h 
without bringing in the global variable.

I didn't really see a use right now for that, but cpu_get_tb_cpu_state 
could be something that may belong in target-*/exec.h more than in 
target-*/cpu.h (no, I'm not going to move it); yet it cannot be moved 
right now because it is called in exec.c.

That said, I think everybody at least agrees on the first 3 patches, is 
it possible to get at least (v2 of) thos applied?

Paolo