[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 08/11] ide: Replace IDEState members is_cdrom, i
|
From: |
Markus Armbruster |
|
Subject: |
[Qemu-devel] Re: [PATCH 08/11] ide: Replace IDEState members is_cdrom, is_cf by drive_kind |
|
Date: |
Tue, 06 Jul 2010 14:38:59 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Am 30.06.2010 13:55, schrieb Markus Armbruster:
>> The two aren't independent variables. Make that obvious.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> Can we please call the constant IDE_CDROM or something else that is easy
> to distinguish? With this patch, we have IDE_CD and IDE_CF, which is an
> easy typo to make.
I renamed IDE_CF to IDE_CFATA. Hope that's okay.