[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix io-thread build breakage of a88790a14f
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH] Fix io-thread build breakage of a88790a14f |
Date: |
Tue, 06 Jul 2010 17:54:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Anthony Liguori wrote:
> On 07/06/2010 03:49 AM, Jan Kiszka wrote:
>> Nigel Horne wrote:
>>
>>> ./configure --enable-linux-aio --enable-io-thread --enable-kvm
>>> make
>>> ...
>>> /home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first
>>> use in this function)
>>> /home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier is
>>> reported only once
>>> /home/njh/src/qemu/cpus.c:532: error: for each function it appears in.)
>>>
>>> Perhaps cpus.c needs to have:
>>>
>>> extern volatile sig_atomic_t exit_request;
>>>
>> Better include the header:
>>
>> ---------->
>>
>> Signed-off-by: Jan Kiszka<address@hidden>
>>
>
> Applied. Thanks.
>
> In the future, please try to avoid quoting in like this. I often forget
> to remove it from the commit message before pushing (although I did in
> this case).
OK.
Note that there is also 'git am -c' - but I used a non-standard scissors
line here...
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux