[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 4/8] block QMP: Drop query-block member "type" (
From: |
Daniel P. Berrange |
Subject: |
[Qemu-devel] Re: [PATCH 4/8] block QMP: Drop query-block member "type" (type= in info block) |
Date: |
Tue, 6 Jul 2010 17:45:13 +0100 |
User-agent: |
Mutt/1.4.1i |
On Tue, Jul 06, 2010 at 06:39:53PM +0200, Kevin Wolf wrote:
> Am 06.07.2010 14:37, schrieb Markus Armbruster:
> > Its value is unreliable: a block device used as floppy has type
> > "floppy" if created with if=floppy, but type "hd" if created with
> > if=none.
> >
> > That's because with if=none, the type is at best a declaration of
> > intent: the drive can be connected to any guest device. Its type is
> > really the guest device's business. Reporting it here is wrong.
> >
> > Signed-off-by: Markus Armbruster <address@hidden>
>
> Dan, I'd like to have your Acked-by for this patch before applying it.
> Can libvirt handle such a change in the monitor output, or does it even
> use info block?
We don't use the 'info block' or query-block commands at this
point in time, only 'info blockstats'/'query-blockstats'. So
it should be fine to drop this field from libvirt's POV.
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
- [Qemu-devel] [PATCH 0/8] Split ide-drive and scsi-disk qdevs, and more, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 1/8] virtio-pci: Check for virtio_blk_init() failure, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 8/8] block: Remove type hint, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 4/8] block QMP: Drop query-block member "type" (type= in info block), Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 7/8] blockdev: Store -drive option media in DriveInfo, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 3/8] ide scsi virtio-blk: Reject empty drives unless media is removable, Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 6/8] scsi: Split qdev "scsi-disk" into "scsi-hd" and "scsi-cd", Markus Armbruster, 2010/07/06
- [Qemu-devel] [PATCH 5/8] ide: Split qdev "ide-drive" into "ide-hd" and "ide-cd", Markus Armbruster, 2010/07/06