[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help |
Date: |
Wed, 21 Jul 2010 22:32:38 +0100 |
User-agent: |
Mutt/1.4.1i |
On Wed, Jul 21, 2010 at 03:55:28PM -0500, Anthony Liguori wrote:
> On 07/21/2010 03:32 PM, Bruce Rogers wrote:
> >Libvirt parses qemu help output to determine qemu features. In particular
> > it probes for the following: "cache=writethrough|writeback|none". The
> > addition of the unsafe cache mode was inserted within this string, as
> > opposed to being added to the end, which impacted libvirt's probe.
> > Unbreak libvirt by keeping the existing cache modes intact and add
> > unsafe to the end.
> >
> >This problem only manifests itself if a caching mode is explicitly
> >specified in the libvirt xml, in which case older syntax for caching is
> >passed to qemu, which it no longer understands.
> >
> >Signed-off-by: Bruce Rogers<address@hidden>
> >
>
> Errr, libvirt is still doing this?
>
> This comes up frequently and it's a real PITA. Help text is not a
> feature probing interface. This is a libvirt bug and it needs to be
> fixed in libvirt
Of course, there is no viable alternative yet. The QMP patches I
sent a few weeks back now to add ability to query capabilities were
intended to provide the neccessary support in QEMU for us to use
instead of -help. Given that QMP isn't going to be declared stable
in 0.13 though, it looks like we'll be continuing to use -help
until the 0.14 release of QEMU.
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
- [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Bruce Rogers, 2010/07/21
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Anthony Liguori, 2010/07/21
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help,
Daniel P. Berrange <=
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Anthony Liguori, 2010/07/21
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Daniel P. Berrange, 2010/07/21
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Anthony Liguori, 2010/07/21
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Jamie Lokier, 2010/07/21
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Markus Armbruster, 2010/07/22
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Daniel P. Berrange, 2010/07/22
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Anthony Liguori, 2010/07/22
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Markus Armbruster, 2010/07/23
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Anthony Liguori, 2010/07/26
- Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help, Avi Kivity, 2010/07/26