qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Add new user mode option -ignore-environment


From: Stefan Weil
Subject: Re: [Qemu-devel] [PATCH] Add new user mode option -ignore-environment
Date: Sun, 01 Aug 2010 13:48:24 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100620 Iceowl/1.0b1 Icedove/3.0.5

Am 16.07.2010 15:09, schrieb Stefan Weil:
Am 16.07.2010 09:04, schrieb Markus Armbruster:
Stefan Weil<address@hidden>  writes:

An empty environment is sometimes useful in user mode.
The new option provides it for linux-user and bsd-user
(darwin-user still has no environment related options).
Stupid question: why is /usr/bin/env insufficient?

[...]


In most cases it is sufficient (but not always available - Windows...).
The options -U and -E are also redundant and can be replaced by
/usr/bin/env.

But -U and -E exist, so completing the set of environment related
options seems to be logical. The name of the new option was
inspired by /usr/bin/env!

And finally, there is a use case where /usr/bin/env is a bad choice:
just look for "getenv" and you will find one in linux-user/main.c.
Removing the environment via /usr/bin/env will also remove
environment variables which are read by qemu's runtime code.


Is there any more feedback on this patch?
Or can it be commited to git master?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]