|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems |
Date: | Wed, 11 Aug 2010 18:07:44 -0400 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Thunderbird/3.0.5 |
On 08/11/2010 02:32 PM, Cam Macdonell wrote:
On Wed, Aug 11, 2010 at 2:28 PM, Stefan Weil<address@hidden> wrote:Am 11.08.2010 20:16, schrieb Cam Macdonell:--- kvm-stub.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/kvm-stub.c b/kvm-stub.c index 3378bd3..d45f9fa 100644 --- a/kvm-stub.c +++ b/kvm-stub.c @@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t addr, uint16_t val, bool assign) { return -ENOSYS; } + +int kvm_set_ioeventfd_mmio_long(int fd, uint32_t adr, uint32_t val, bool assign) +{ + return -ENOSYS; +}Your 2nd patch disables build of ivshmem.o on non-kvm systems. Only ivshmem.c was using kvm_set_ioeventfd_mmio_long, so up to now, no dummy function in kvm-stub.c is needed.Right. It can be left out for now if that's preferred.
No, your patch is correct. If kvm-stub.c is not complete, the build will break the next time someone uses one of those functions.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |