[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/15] xen: Initialize event channels and io rin
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH 09/15] xen: Initialize event channels and io rings |
Date: |
Fri, 13 Aug 2010 14:10:10 +0100 |
User-agent: |
Alpine 2.00 (DEB 1167 2008-08-23) |
On Thu, 12 Aug 2010, Blue Swirl wrote:
> > +static inline void read_physical(uint64_t addr, unsigned long size, void
> > *val)
> > +{
> > + return cpu_physical_memory_rw((target_phys_addr_t)addr, val, size, 0);
> > +}
> > +
> > +static inline void write_physical(uint64_t addr, unsigned long size, void
> > *val)
> > +{
> > + return cpu_physical_memory_rw((target_phys_addr_t)addr, val, size, 1);
> > +}
>
> Useless redirection?
>
I guess we can just use cpu_physical_memory_read/write instead of
read_physical and write_physical here.
Ok also to all the other comments.
- Re: [Qemu-devel] [PATCH 12/15] piix_pci: introduce a write_config notifier, (continued)
- [Qemu-devel] [PATCH 06/15] xen: Add the Xen platform pci device, stefano . stabellini, 2010/08/12
- [Qemu-devel] [PATCH 05/15] xen: add a 8259 Interrupt Controller, stefano . stabellini, 2010/08/12
- [Qemu-devel] [PATCH 11/15] piix3: introduce register_set_irq and register_map_irq, stefano . stabellini, 2010/08/12
- [Qemu-devel] [PATCH 09/15] xen: Initialize event channels and io rings, stefano . stabellini, 2010/08/12
- [Qemu-devel] [PATCH 15/15] xen: Add a Xen specific ACPI Implementation to target-xen, stefano . stabellini, 2010/08/12
[Qemu-devel] [PATCH 13/15] vl.c: Introduce getter for shutdown_requested and reset_requested., stefano . stabellini, 2010/08/12
[Qemu-devel] [PATCH 03/15] xen: Add a new target to qemu: target-xen, stefano . stabellini, 2010/08/12