Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

[Avi Kivity]

 On 08/22/2010 11:20 PM, Jes Sorensen wrote:
> > I happen to like the single line braces rule.  That is, I don't like how
> > the code looks (I dislike punctuation generally), but I like the
> > consistency and I like how patches that add or remove a line are easy to
> > read.
> >
> > My preference would be: new code has to adhere to the new style.
> Agreed, once we pick something, make the new stuff stick to that. The
> main issue is when you make mods to a file that is using a different
> style. It's not ideal that you add one line of the new style and the
> rest is the old way.

I happen not to care too much but that's a personal thing I guess.

> > Perhaps we can have a bot subscribed to the list issue auto-reviews if
> > things are incorrect.
> That might work.

Anyone for a Google Weekend of Code?

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.