Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

[Jes Sorensen]

On 08/22/10 20:13, Blue Swirl wrote:
> Well, consider for example mass braces conversion to the One Style,
> whichever that is. Would it be better to do it in one commit or
> multiple commits? If the latter, push all commits back-to-back or just
> one at a time now and then?
> 
> At the extreme end, we could even convert one statement per commit.
> This would make bug hunting with git bisect extremely precise. There
> would be a cost of long commit log.
> 
> For the patch submitters, wouldn't one shot conversion (with one push,
> one or many commits) be less painful?

Hi,

Yes, if we do it, I'd say one commit per file/file-set, like hw/irq.[ch]
etc.

>> and has elements making it harder to debug the code, like
>> the braces around single line if statements.
> 
> What's the problem?

It chews up lines for no reason giving you less of an overview of the
code. Obviously there are cases where it makes sense, but having it
around a return statement is just a waste.

>> I totally agree with Markus
>> that it seems like wasted effort to come up with new tools and having to
>> maintain them when there are good ones out there like the ones from the
>> Linux kernel.
> 
> I also find the tool argument very attractive. No other style has that 
> benefit.

Yes, it's a big win.

Cheers,
Jes