[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped |
Date: |
Thu, 26 Aug 2010 13:47:50 +0530 |
User-agent: |
Mutt/1.5.20 (2009-12-10) |
On (Thu) Aug 26 2010 [10:05:44], Paolo Bonzini wrote:
> On 08/26/2010 08:05 AM, Amit Shah wrote:
> >This is what I have currently. It would need some timer handling in
> >the save/load case as well, right?
>
> When loading you won't have any pending "info balloon" command, so I
> think the timer need not be preserved across migration.
>
> Also, 5 seconds for a stopped guest is actually a lot,
That's the problem; it's policy. Where and how to specify it?
> so maybe
> Amit's original patch or a variant thereof would make sense anyway.
This seems to be needed though -- as Anthony mentioned, a guest which
has oopsed or similar, incapable of servicing the stats request, is
going to block the monitor command from returning forever.
So it's better to have a timeout, just that we need to decide how much
it should be.
Amit
- [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped, Amit Shah, 2010/08/19
- [Qemu-devel] Re: [PATCH V2] balloon: Don't try fetching info if machine is stopped, Paolo Bonzini, 2010/08/20
- Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped, Amit Shah, 2010/08/20
- Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped, Anthony Liguori, 2010/08/22
- Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped, Daniel P. Berrange, 2010/08/23
- Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped, Amit Shah, 2010/08/26
- Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped, Amit Shah, 2010/08/26
- Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped,
Amit Shah <=
- Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped, Paolo Bonzini, 2010/08/26
- Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped, Daniel P. Berrange, 2010/08/26
- Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped, Luiz Capitulino, 2010/08/26
- Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped, Paolo Bonzini, 2010/08/26