qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qdev: Reset hotplugged devices


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] qdev: Reset hotplugged devices
Date: Thu, 26 Aug 2010 08:02:38 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100713 Lightning/1.0b1 Thunderbird/3.0.6

On 08/26/2010 03:38 AM, Isaku Yamahata wrote:

I think that starts by understanding exactly what's guaranteed and
understanding what the use cases are for it.
Fair enough. How about the followings?

Thanks for enumerating.

This is just a starting point. I borrowed terminology pci/pcie spec.


reset
        Bring the state of hardware state to consistent state.
        (some state might be left unknown.)
        

system reset
        a hardware mechanism for setting or returning all hardware states
        to the initial conditions.
        Use case:
        In qemu, system_system_reset().


cold reset(power on reset)
        system reset following the application of power.
        Use case:
        In qemu, system_reset() in main().
        We might want to use this as a power cycle.
        When a device is hot plugged, the device should be cold reset too.
        This is your motivation.
        QEMU_RESET_COLD
        Guarantee:
        The internal status must be same to qdev_init() + qdev_reset()

This is what we do today in QEMU and from a functional perspective it covers the type of function we need today.

        
warm reset
        system reset without cycling the supplied power.
        Use case:
        In qemu, system_reset() in main_loop(). There are many places
        which calls qemu_system_reset_request().
        Some state are retained across warm reset. Like PCIe AER, error
        reporting registers need to keep its contents across warm reset
        as OS would examine them and report it when hardware errors caused
        warm reset.
        QEMU_RESET_WARM

With AER, I can't imagine that this matters that much unless we're doing PCI passthrough, right?

So maybe the way we should frame this discussion is, what's the type of reset semantics that we need to support for PCI passthrough? The next question after that is how do we achieve the different types of reset for passthrough devices?

BTW, if you could transfer some of this discussion to a wiki page on qemu.org, I think that would be extremely valuable.

Regards,

Anthony Liguori

bus reset
        Reset bus and devices on the bus.
        Bus reset is usually triggered when cold reset, warm reset and
        commanding the bus controller to reset the child bus.
        When bus reset is triggered as command to bus controller,
        the effect is usually same to warm reset on devices on the bus.

        Typically on parallel bus, bus reset is started by asserting
        a designated signal.
        Example: PCI RST#, ATA RESET-, SCSI RST
        
        Use case:
        bus reset as result of programming bus controller.
        Qemu is currently missing it which I'd like to fill for pci bus.
        ATA and SCSI could benefit from this.
        QEMU_RESET_WARM with bus.
        Guarantee:
        device state under the bus is same as warm reset.


device/function reset:
        Reset triggered by sending reset command to a device.
        This is bus/device specific.
        There might be many reset commands whose effects are different.
        Example: PCI FLR, ATA DEVICE RESET command,
                  scsi bus device reset message.

        This reset is bus specific, so it wouldn't be suitable for qdev
        frame work and could be handled by each bus level.

        
hot reset:
        I just put it here for completeness because pcie defines hot reset.
        A reset propagated in-band across a Link using a Physical Layer
        mechanism.
        Qemu doesn't emulate physical layer, so we don't care it.
        From software point of view, hot reset has same effect to warm reset.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]