Re: [Qemu-devel] [PATCH 1/3] Add TPM 1.2 host device passthrough interface

[Anthony Liguori]

On 08/26/2010 04:44 PM, malc wrote:
> >      
> > > and lastly there is no errx[1]
> > >
> > > [..snip..]
> > >
> > > [1] err(3):
> > >     CONFORMING TO
> > >        These functions are non-standard BSD extensions.
> > >        
> > err() and errx() are already used somewhere. But these should be
> > converted to error_report etc., like other printf based local
> > functions.
> >
> >      
> Only in Linux specific nbd code.
>    

And the nbd stuff is derived from non-QEMU code that was brought into 
the tree.  It's generally a bad example of QEMU coding style.

Regards,

Anthony Liguori