[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH -V4 03/26] virtio-9p: Return correct error from v9fs
From: |
Venkateswararao Jujjuri (JV) |
Subject: |
[Qemu-devel] [PATCH -V4 03/26] virtio-9p: Return correct error from v9fs_remove |
Date: |
Sun, 29 Aug 2010 12:02:29 -0700 |
From: Sripathi Kodi <address@hidden>
Signed-off-by: Sripathi Kodi <address@hidden>
In v9fs_remove_post_remove() we currently ignore the error returned by
the previous call to remove() and return an error only if freeing the
fid fails. However, the client expects to see the error from remove().
Currently the client falsely thinks that the remove call has always
succeeded. For example, doing rmdir on a non-empty directory does
not return ENOTEMPTY.
With this patch we ignore the error from free_fid(). The client cannot
use this error value anyway.
Signed-off-by: Sripathi Kodi <address@hidden>
Signed-off-by: Venkateswararao Jujjuri <address@hidden>
---
hw/virtio-9p.c | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c
index f385183..cea3935 100644
--- a/hw/virtio-9p.c
+++ b/hw/virtio-9p.c
@@ -1877,14 +1877,15 @@ static void v9fs_flush(V9fsState *s, V9fsPDU *pdu)
static void v9fs_remove_post_remove(V9fsState *s, V9fsRemoveState *vs,
int err)
{
- /* For TREMOVE we need to clunk the fid even on failed remove */
- err = free_fid(s, vs->fidp->fid);
if (err < 0) {
- goto out;
+ err = -errno;
+ } else {
+ err = vs->offset;
}
- err = vs->offset;
-out:
+ /* For TREMOVE we need to clunk the fid even on failed remove */
+ free_fid(s, vs->fidp->fid);
+
complete_pdu(s, vs->pdu, err);
qemu_free(vs);
}
--
1.6.5.2
- [Qemu-devel] [PATCH -V4 17/26] virtio-9p: Add fidtype so that we can do type specific operation, (continued)
- [Qemu-devel] [PATCH -V4 17/26] virtio-9p: Add fidtype so that we can do type specific operation, Venkateswararao Jujjuri (JV), 2010/08/29
- [Qemu-devel] [PATCH -V4 19/26] virtio-9p: Implement TXATTRCREATE, Venkateswararao Jujjuri (JV), 2010/08/29
- [Qemu-devel] [PATCH -V4 20/26] virtio-9p: Hide user.virtfs xattr in case of mapped security., Venkateswararao Jujjuri (JV), 2010/08/29
- [Qemu-devel] [PATCH -V4 22/26] virtio-9p: Use lchown which won't follow symlink, Venkateswararao Jujjuri (JV), 2010/08/29
- [Qemu-devel] [PATCH -V4 25/26] [virtio-9p] This patch implements TLERROR/RLERROR on the qemu 9P server., Venkateswararao Jujjuri (JV), 2010/08/29
- [Qemu-devel] [PATCH -V4 24/26] [virtio-9p] Remove all instances of unnecessary dotu variable., Venkateswararao Jujjuri (JV), 2010/08/29
- [Qemu-devel] [PATCH -V4 23/26] virtio-9p: Fix the memset usage, Venkateswararao Jujjuri (JV), 2010/08/29
- [Qemu-devel] [PATCH -V4 26/26] virtio-9p: Change handling of flags in open() path for 9P2000.L, Venkateswararao Jujjuri (JV), 2010/08/29
- [Qemu-devel] [PATCH -V4 21/26] virtio-9p: Add SM_NONE security model, Venkateswararao Jujjuri (JV), 2010/08/29
- [Qemu-devel] [PATCH -V4 04/26] [V4] virtio-9p: readdir implementation for 9p2000.L, Venkateswararao Jujjuri (JV), 2010/08/29
- [Qemu-devel] [PATCH -V4 03/26] virtio-9p: Return correct error from v9fs_remove,
Venkateswararao Jujjuri (JV) <=