[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH v3 2/3] qerror: Add a new MACHINE_STOPPED er
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] Re: [PATCH v3 2/3] qerror: Add a new MACHINE_STOPPED error message |
Date: |
Mon, 30 Aug 2010 17:01:58 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Anthony Liguori <address@hidden> writes:
> On 08/30/2010 03:30 AM, Markus Armbruster wrote:
>> Amit Shah<address@hidden> writes:
>>
>>
>>> On (Fri) Aug 27 2010 [07:39:37], Anthony Liguori wrote:
>>>
>>>>> NACK. It has always been allowed& valid to call query-balloon
>>>>> to get the current balloon level. We must not throw an error
>>>>> just because the recently added mem stats can't be refreshed.
>>>>>
>>>> I think that's a fair comment but why even bother fixing the
>>>> command. Let's introduce a new command that just gets a single
>>>> piece of information instead of having a command return lots of
>>>> information.
>>>>
>>> Instead, let's have query-balloon do the same thing as it did in 0.12
>>> and add a new command for 0.13 (query-balloon-stats) that does the stats
>>> with timeout?
>>>
>>> That way we won't have regressions from 0.12 and have the new behaviour
>>> only for 0.13, which we can say is 'experimental'.
>>>
>> Sounds sensible to me. Not too late for fixing 0.13? Anthony?
>>
>
> No new commands for 0.13. I think the only option is to revert the
> query-balloon behavior. A new command is too risky as -rc1 is
> imminent.
Anyone care to submit a patch?
- [Qemu-devel] Re: Should QMP be RPC to internal C interfaces?, (continued)
- [Qemu-devel] Re: Should QMP be RPC to internal C interfaces?, Luiz Capitulino, 2010/08/30
- [Qemu-devel] Re: Should QMP be RPC to internal C interfaces?, Anthony Liguori, 2010/08/30
- [Qemu-devel] Re: Should QMP be RPC to internal C interfaces?, Markus Armbruster, 2010/08/31
- [Qemu-devel] Re: Should QMP be RPC to internal C interfaces?, Luiz Capitulino, 2010/08/31
- [Qemu-devel] Re: Should QMP be RPC to internal C interfaces?, Anthony Liguori, 2010/08/31
- [Qemu-devel] Re: Should QMP be RPC to internal C interfaces?, Markus Armbruster, 2010/08/31
- [Qemu-devel] Re: Should QMP be RPC to internal C interfaces?, Anthony Liguori, 2010/08/31
- [Qemu-devel] Re: [PATCH v3 2/3] qerror: Add a new MACHINE_STOPPED error message, Amit Shah, 2010/08/27
- Re: [Qemu-devel] Re: [PATCH v3 2/3] qerror: Add a new MACHINE_STOPPED error message, Markus Armbruster, 2010/08/30
- Re: [Qemu-devel] Re: [PATCH v3 2/3] qerror: Add a new MACHINE_STOPPED error message, Anthony Liguori, 2010/08/30
- Re: [Qemu-devel] Re: [PATCH v3 2/3] qerror: Add a new MACHINE_STOPPED error message,
Markus Armbruster <=
- [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface, Adam Litke, 2010/08/30
- [Qemu-devel] Re: [PATCH] Disable virtio-balloon memory stats interface, Amit Shah, 2010/08/30
[Qemu-devel] [PATCH v3 3/3] balloon: Don't try fetching info if machine is stopped, Amit Shah, 2010/08/27