[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 1/7] pci: expand tabs to spaces in pci_regs.h
From: |
Eduard - Gabriel Munteanu |
Subject: |
[Qemu-devel] Re: [PATCH 1/7] pci: expand tabs to spaces in pci_regs.h |
Date: |
Wed, 1 Sep 2010 01:58:30 +0300 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Tue, Aug 31, 2010 at 11:29:53PM +0300, Michael S. Tsirkin wrote:
> On Sat, Aug 28, 2010 at 05:54:52PM +0300, Eduard - Gabriel Munteanu wrote:
> > The conversion was done using the GNU 'expand' tool (default settings)
> > to make it obey the QEMU coding style.
> >
> > Signed-off-by: Eduard - Gabriel Munteanu <address@hidden>
>
> I'm not really interested in this: we copied pci_regs.h from linux
> to help non-linux hosts, and keeping the code consistent
> with the original makes detecting bugs and adding new stuff
> from linux/pci_regs.h easier.
>
> > ---
> > hw/pci_regs.h | 1330
> > ++++++++++++++++++++++++++++----------------------------
> > 1 files changed, 665 insertions(+), 665 deletions(-)
> > rewrite hw/pci_regs.h (90%)
Ok, I'll drop it. The only reason I did it was one of my additions to
this file made the patch look indented awkwardly.
I'll use tabs and merge it into Linux as well.
Thanks,
Eduard