[Qemu-devel] Re: [PATCH v6] Introduce qemu_madvise()

[Andreas Färber]

Am 15.09.2010 um 21:50 schrieb Blue Swirl:

> On Wed, Sep 15, 2010 at 7:35 PM, Andreas Färber <address@hidden 
> > wrote:
> > Maybe return -1 and set errno to the posix_madvise() return code?  
> > (but is it
> > errno = -retval or errno = retval then?)
>
> An advantage of posix_madvise() semantics is that no mucking with
> errno is needed. Though existing code should be checked if they rely
> on madvise() semantics instead.

perror() after the MADV_DONTFORK failure does, right?

Andreas