[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] qcow2: Move sync out of update_refcount
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/4] qcow2: Move sync out of update_refcount |
|
Date: |
Fri, 17 Sep 2010 19:19:21 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7 |
Am 17.09.2010 19:06, schrieb Anthony Liguori:
> On 09/17/2010 11:18 AM, Kevin Wolf wrote:
>> Note that the flush is omitted intentionally in qcow2_free_clusters. If
>> anything, we can leak clusters here if we lose the writes.
>>
>> Signed-off-by: Kevin Wolf<address@hidden>
>>
>
> Cluster leaking gets picked up by bdrv_check though, right?
>
> I think I've convinced myself that leaking clusters is not an acceptable
> behavior from a security perspective but as long as it's detectable via
> bdrv_check, qcow2 could implement an online check to address it.
Leaking clusters on crashes is unavoidable. But yes, qemu-img check does
detect this.
Kevin
- [Qemu-devel] [PATCH 0/4] qcow2: Save another common flush, Kevin Wolf, 2010/09/17
- [Qemu-devel] [PATCH 2/4] qcow2: Move sync out of update_refcount, Kevin Wolf, 2010/09/17
- [Qemu-devel] [PATCH 1/4] qcow2: Move sync out of write_refcount_block_entries, Kevin Wolf, 2010/09/17
- [Qemu-devel] [PATCH 3/4] qcow2: Move sync out of qcow2_alloc_clusters, Kevin Wolf, 2010/09/17
- [Qemu-devel] [PATCH 4/4] qcow2: Get rid of additional sync on COW, Kevin Wolf, 2010/09/17
- Re: [Qemu-devel] [PATCH 0/4] qcow2: Save another common flush, Anthony Liguori, 2010/09/17