[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Avoid exit in trap as it breaks with some shell
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH] Avoid exit in trap as it breaks with some shells |
Date: |
Sun, 26 Sep 2010 06:58:45 +0000 |
Thanks, applied. Please remember to add the Signed-off-line.
On Sat, Sep 25, 2010 at 7:52 PM, Loïc Minier <address@hidden> wrote:
> Don't call exit in the trap handler as it causes the return code to be
> zero with some buggy shells (dash and pdksh at least) and is useless
> here anyway.
> ---
> configure | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index 3bfc5e9..9d3acfc 100755
> --- a/configure
> +++ b/configure
> @@ -15,7 +15,9 @@ TMPC="${TMPDIR1}/qemu-conf-${RANDOM}-$$-${RANDOM}.c"
> TMPO="${TMPDIR1}/qemu-conf-${RANDOM}-$$-${RANDOM}.o"
> TMPE="${TMPDIR1}/qemu-conf-${RANDOM}-$$-${RANDOM}.exe"
>
> -trap "rm -f $TMPC $TMPO $TMPE ; exit" EXIT INT QUIT TERM
> +# NB: do not call "exit" in the trap handler; this is buggy with some shells;
> +# see <address@hidden>
> +trap "rm -f $TMPC $TMPO $TMPE" EXIT INT QUIT TERM
>
> compile_object() {
> $cc $QEMU_CFLAGS -c -o $TMPO $TMPC > /dev/null 2> /dev/null
> --
> 1.7.1
>
>
>
- [Qemu-devel] [PATCH] Don't exit with zero in the trap handler, Loïc Minier, 2010/09/24
- Re: [Qemu-devel] [PATCH] Don't exit with zero in the trap handler, Markus Armbruster, 2010/09/25
- Re: [Qemu-devel] [PATCH] Don't exit with zero in the trap handler, Loïc Minier, 2010/09/25
- Re: [Qemu-devel] [PATCH] Don't exit with zero in the trap handler, Blue Swirl, 2010/09/25
- Re: [Qemu-devel] [PATCH] Don't exit with zero in the trap handler, Loïc Minier, 2010/09/25
- Re: [Qemu-devel] [PATCH] Don't exit with zero in the trap handler, Markus Armbruster, 2010/09/25
- Re: [Qemu-devel] [PATCH] Don't exit with zero in the trap handler, Blue Swirl, 2010/09/25
- [Qemu-devel] [PATCH] Avoid exit in trap as it breaks with some shells, Loïc Minier, 2010/09/25
- Re: [Qemu-devel] [PATCH] Avoid exit in trap as it breaks with some shells,
Blue Swirl <=