[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/18] Monitor: Introduce find_dispatch_table()
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 01/18] Monitor: Introduce find_dispatch_table() |
Date: |
Wed, 29 Sep 2010 11:29:24 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Luiz Capitulino <address@hidden> writes:
> It's a generic version of monitor_find_command() which searches
> the dispatch table passed as an argument.
>
> Future commits will introduce new dispatch tables, so we need
> common code to search them.
>
> Signed-off-by: Luiz Capitulino <address@hidden>
> ---
> monitor.c | 10 ++++++++--
> 1 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index e602480..98fc57a 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3368,11 +3368,12 @@ static int is_valid_option(const char *c, const char
> *typestr)
> return (typestr != NULL);
> }
>
> -static const mon_cmd_t *monitor_find_command(const char *cmdname)
> +static const mon_cmd_t *find_dispatch_table(const mon_cmd_t *disp_table,
> + const char *cmdname)
find_dispatch_table() suggests it's searching for a dispatch table.
What about search_dispatch_table() or lookup_command()?
> {
> const mon_cmd_t *cmd;
>
> - for (cmd = mon_cmds; cmd->name != NULL; cmd++) {
> + for (cmd = disp_table; cmd->name != NULL; cmd++) {
> if (compare_cmd(cmdname, cmd->name)) {
> return cmd;
> }
> @@ -3381,6 +3382,11 @@ static const mon_cmd_t *monitor_find_command(const
> char *cmdname)
> return NULL;
> }
>
> +static const mon_cmd_t *monitor_find_command(const char *cmdname)
> +{
> + return find_dispatch_table(mon_cmds, cmdname);
> +}
> +
> static const mon_cmd_t *monitor_parse_command(Monitor *mon,
> const char *cmdline,
> QDict *qdict)
- [Qemu-devel] [PATCH 00/18] Monitor: split HMP and QMP dispatch tables, Luiz Capitulino, 2010/09/16
- [Qemu-devel] [PATCH 01/18] Monitor: Introduce find_dispatch_table(), Luiz Capitulino, 2010/09/16
- Re: [Qemu-devel] [PATCH 01/18] Monitor: Introduce find_dispatch_table(),
Markus Armbruster <=
- [Qemu-devel] [PATCH 02/18] QMP: handle_qmp_command(): Move 'cmd' sanity check, Luiz Capitulino, 2010/09/16
- [Qemu-devel] [PATCH 03/18] QMP: Don't use do_info(), Luiz Capitulino, 2010/09/16
- [Qemu-devel] [PATCH 04/18] Monitor: Drop QMP bits from do_info(), Luiz Capitulino, 2010/09/16
- [Qemu-devel] [PATCH 05/18] Monitor: Drop is_async_return(), Luiz Capitulino, 2010/09/16
- [Qemu-devel] [PATCH 06/18] Monitor: Convert do_info() back to HMP, Luiz Capitulino, 2010/09/16