qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/2] powerpc: Add a virtex5 ml507 refdesign boar


From: Stefan Weil
Subject: Re: [Qemu-devel] [PATCH 0/2] powerpc: Add a virtex5 ml507 refdesign board (v2)
Date: Sat, 02 Oct 2010 13:02:50 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100913 Iceowl/1.0b1 Icedove/3.0.7

Am 30.09.2010 19:12, schrieb Edgar E. Iglesias:
On Thu, Sep 30, 2010 at 03:15:54PM +0200, Alexander Graf wrote:
Edgar E. Iglesias wrote:
v2:
* Address review comments from A. Graf.

Edgar E. Iglesias (2):
powerpc: Add a ppc-440x5 Xilinx model
powerpc: Add a virtex5 ml507 refdesign board

Makefile.target | 8 +
default-configs/ppc-softmmu.mak | 2 +
default-configs/ppc64-softmmu.mak | 2 +
default-configs/ppcemb-softmmu.mak | 2 +
hw/virtex_ml507.c | 278 ++++++++++++++++++++++++++++++++++++
target-ppc/cpu.h | 4 +
target-ppc/translate_init.c | 6 +-
7 files changed, 300 insertions(+), 2 deletions(-)
create mode 100644 hw/virtex_ml507.c



No complaints from me. Feel free to apply them.

Signed-off-by: Alexander Graf <address@hidden>

Applied, thanks.

Cheers



What about coding conventions?
New source files should comply with CODING_STYLE (block structure).

virtex_ml507.c:

+ if (!fdt)
+ return 0;

Cheers,





reply via email to

[Prev in Thread] Current Thread [Next in Thread]