qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 2/4] trace: Don't strip lines containing '#' arbitra


From: Stefan Hajnoczi
Subject: [Qemu-devel] [PATCH 2/4] trace: Don't strip lines containing '#' arbitrarily
Date: Tue, 5 Oct 2010 14:28:51 +0100

Although comment lines must be skipped, the '#' character can occur in
valid format strings.  Be more careful when checking for comments.
Leave comments at the end of the line where they will not interfere with
other processing.

Signed-off-by: Stefan Hajnoczi <address@hidden>
---
 tracetool |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/tracetool b/tracetool
index 534cc70..63e3e29 100755
--- a/tracetool
+++ b/tracetool
@@ -318,8 +318,7 @@ convert()
 
     while read -r str; do
         # Skip comments and empty lines
-        str=${str%%#*}
-        test -z "$str" && continue
+        test -z "${str%%#*}" && continue
 
         # Process the line.  The nop backend handles disabled lines.
         disable=${str%%disable *}
-- 
1.7.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]