qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation


From: Edgar E. Iglesias
Subject: Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation
Date: Tue, 5 Oct 2010 19:00:03 +0200
User-agent: Mutt/1.5.20 (2009-06-14)

On Tue, Oct 05, 2010 at 06:42:34PM +0200, Alexander Graf wrote:
> 
> On 02.10.2010, at 20:17, John Clark wrote:
> 
> >> Hi,
> >> 
> >> Alex:
> >> I think you've missed the part of the patch that renames the _lo -> _hi.
> >> As John says, qemu had the hi/lo parts reversed when reading 4xx TLB regs.
> >> 
> >> Except for the comments and the define, the patch looks good to me.
> >> John, please also add a Signed-off-by line.
> >> 
> >> Cheers
> > 
> > Ok, I have removed the superfluous comments, added defines for magic
> > numbers, added braces to conform to the QEMU coding style guidelines,
> > and regression tested it in my system.  Patch included below.
> > 
> > Thanks.
> > 
> > - John
> > 
> > Signed-off-by: John Clark <address@hidden>
> 
> Signed-off-by: Alexander Graf <address@hidden>

Applied, thanks John and Alex.

Cheers



reply via email to

[Prev in Thread] Current Thread [Next in Thread]