[Qemu-devel] Re: [patch uq/master 7/8] MCE: Relay UCR MCE to guest

[Marcelo Tosatti]

On Wed, Oct 06, 2010 at 10:10:51AM +0900, Hidetoshi Seto wrote:
> 
> (snip)
> 
> > Index: qemu/kvm.h
> > ===================================================================
> > --- qemu.orig/kvm.h
> > +++ qemu/kvm.h
> > @@ -110,6 +110,9 @@ int kvm_arch_init_vcpu(CPUState *env);
> >  
> >  void kvm_arch_reset_vcpu(CPUState *env);
> >  
> > +int kvm_on_sigbus(CPUState *env, int code, void *addr);
> > +int kvm_on_sigbus_vcpu(int code, void *addr);
> > +
> >  struct kvm_guest_debug;
> >  struct kvm_debug_exit_arch;
> >  
> 
> So kvm_on_sigbus() is called from qemu_kvm_eat_signal() that is
> called on vcpu thread, while kvm_on_sigbus_vcpu() is called via
> sigbus_handler that invoked on iothread using signalfd.
> 
> ... Inverse naming?

Yes, fixed.