qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 08/11] vnc: avoid write only variables


From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH 08/11] vnc: avoid write only variables
Date: Thu, 07 Oct 2010 09:23:17 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100907 Fedora/3.1.3-1.fc13 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.3

On 10/06/2010 11:33 PM, Blue Swirl wrote:
+#if defined(CONFIG_VNC_TLS) || defined(CONFIG_VNC_SASL)
          } else if (strncmp(options, "acl", 3) == 0) {
              acl = 1;
+#endif

Not sure it's okay to reject the option altogether (i.e. maybe the #if should only include "acl = 1".

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]