[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] Switch migrate_set_speed() to take an 'o' a
From: |
Jes Sorensen |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] Switch migrate_set_speed() to take an 'o' argument rather than a float. |
Date: |
Thu, 07 Oct 2010 16:12:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Lightning/1.0b3pre Thunderbird/3.1.4 |
On 09/28/10 12:08, Markus Armbruster wrote:
> address@hidden writes:
>> diff --git a/qemu-monitor.hx b/qemu-monitor.hx
>> index 49bcd8d..7f58fb2 100644
>> --- a/qemu-monitor.hx
>> +++ b/qemu-monitor.hx
>> @@ -1093,7 +1093,7 @@ EQMP
>>
>> {
>> .name = "migrate_set_speed",
>> - .args_type = "value:f",
>> + .args_type = "value:o",
>> .params = "value",
>> .help = "set maximum speed (in bytes) for migrations",
>> .user_print = monitor_user_noop,
>
> Doesn't this change the interpretation of "42" from 42 to (42 << 20)?
It was always so on the command line that a number without a specifier
meant MB. If the monitor defaulted to bytes it will get ugly to support
both defaults in common code.
Cheers,
Jes
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 4/5] Switch migrate_set_speed() to take an 'o' argument rather than a float.,
Jes Sorensen <=