[Qemu-devel] Re: [PATCH 5/6] Switch migrate_set_speed() to take an 'o' argument rather than a float.

[Paolo Bonzini]

On 10/07/2010 05:01 PM, address@hidden wrote:
> From: Jes Sorensen<address@hidden>
>
> Signed-off-by: Jes Sorensen<address@hidden>
> ---
>   hmp-commands.hx |    2 +-
>   migration.c     |    4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 81999aa..95bdb91 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -754,7 +754,7 @@ ETEXI
>
>       {
>           .name       = "migrate_set_speed",
> -        .args_type  = "value:f",
> +        .args_type  = "value:o",
>           .params     = "value",
>           .help       = "set maximum speed (in bytes) for migrations",
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Is this still accurate?

Alternatively, you said it's a mess to distinguish the defaults on the 
command line and the monitor, but is it harder than the attached patch?

Paolo

strtosz.patch
Description: Text document