[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 09/11] i386: avoid a write only variable
From: |
Blue Swirl |
Subject: |
[Qemu-devel] Re: [PATCH 09/11] i386: avoid a write only variable |
Date: |
Thu, 7 Oct 2010 17:32:45 +0000 |
On Thu, Oct 7, 2010 at 7:27 AM, Paolo Bonzini <address@hidden> wrote:
> On 10/06/2010 11:34 PM, Blue Swirl wrote:
>>
>> Compiling with GCC 4.6.0 20100925 produced warnings:
>> /src/qemu/target-i386/op_helper.c: In function 'switch_tss':
>> /src/qemu/target-i386/op_helper.c:283:53: error: variable 'new_trap'
>> set but not used [-Werror=unused-but-set-variable]
>>
>> Fix by deleting the variable.
>
> Again, this warning tells us the emulation is incorrect, so it's wrong to
> remove it.
The warning tells us that the emulation is unfinished.
It's probably unfinished because debugging TSS switches hasn't ever
been needed by anyone. If anyone in the future cares enough about T
bit, it's easy to implement it even after this part has been removed.
But if someone proposes a better patch, I'd be happy to use that
instead of this.