qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH 09/11] i386: avoid a write only variable


From: malc
Subject: Re: [Qemu-devel] Re: [PATCH 09/11] i386: avoid a write only variable
Date: Thu, 7 Oct 2010 21:44:06 +0400 (MSD)
User-agent: Alpine 2.00 (LNX 1167 2008-08-23)

On Thu, 7 Oct 2010, Blue Swirl wrote:

> On Thu, Oct 7, 2010 at 8:27 AM, malc <address@hidden> wrote:
> > On Thu, 7 Oct 2010, Paolo Bonzini wrote:
> >
> >> On 10/06/2010 11:34 PM, Blue Swirl wrote:
> >> > Compiling with GCC 4.6.0 20100925 produced warnings:
> >> > /src/qemu/target-i386/op_helper.c: In function 'switch_tss':
> >> > /src/qemu/target-i386/op_helper.c:283:53: error: variable 'new_trap'
> >> > set but not used [-Werror=unused-but-set-variable]
> >> >
> >> > Fix by deleting the variable.
> >>
> >> Again, this warning tells us the emulation is incorrect, so it's wrong to
> >> remove it.
> >>
> >
> > http://support.amd.com/us/Processor_TechDocs/24593.pdf
> >
> > 12.2.5
> > T (Trap) Bit--â– Bit 0 of byte 64h, static field. This bit, when set to1,
> > causes a debug exception (#DB) to occur on a task switch. See "Beakpoint
> > Instruction (INT3)" page 340 for additional information.
> 
> Yes, I read that before making the patch. But page 340 didn't seem to
> give any relevant information.

13.2.4  Breakpoint Instruction (INT3)
Is what was referred to apparently.

-- 
mailto:address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]