qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] configure: Send error message from spice check


From: Gerd Hoffmann
Subject: [Qemu-devel] Re: [PATCH] configure: Send error message from spice check to /dev/null
Date: Thu, 07 Oct 2010 21:05:49 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100827 Red Hat/3.1.3-1.el6 Thunderbird/3.1.3

On 10/07/10 17:58, Stefan Weil wrote:
pkg-config is not always available (e.g. on win32 hosts),
but we don't want to see the 'command not found' error message.

  compile_object() {
+  echo>>config.log
+  cat $TMPC>>config.log
+  echo>>config.log

This looks unrelated.

@@ -28,6 +31,9 @@ compile_object() {
  compile_prog() {
    local_cflags="$1"
    local_ldflags="$2"
+  echo>>config.log
+  cat $TMPC>>config.log
+  echo>>config.log

This too.

    spice_cflags=$($pkgconfig --cflags spice-protocol spice-server 2>/dev/null)
    spice_libs=$($pkgconfig --libs spice-protocol spice-server 2>/dev/null)
-  if $pkgconfig --atleast-version=0.5.3 spice-server&&\
+  if $pkgconfig --atleast-version=0.5.3 spice-server>/dev/null 2>&1&&  \

Fine with me, the other pkgconfig calls are covered already, the third missing is just an oversight and the fix is ObliviouslyCorrect[tm].

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]